linux-kernel - Re: [patch V6 12/37] x86/entry: Provide idtentry_entry/exit_cond

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200521190410.GB2869@paulmck-ThinkPad-P72>
Date:   Thu, 21 May 2020 12:04:10 -0700
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     Andy Lutomirski <luto@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>, X86 ML <x86@...nel.org>,
        Alexandre Chartre <alexandre.chartre@...cle.com>,
        Frederic Weisbecker <frederic@...nel.org>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Sean Christopherson <sean.j.christopherson@...el.com>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Petr Mladek <pmladek@...e.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Joel Fernandes <joel@...lfernandes.org>,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        Juergen Gross <jgross@...e.com>,
        Brian Gerst <brgerst@...il.com>,
        Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Will Deacon <will@...nel.org>,
        Tom Lendacky <thomas.lendacky@....com>,
        Wei Liu <wei.liu@...nel.org>,
        Michael Kelley <mikelley@...rosoft.com>,
        Jason Chen CJ <jason.cj.chen@...el.com>,
        Zhao Yakui <yakui.zhao@...el.com>,
        "Peter Zijlstra (Intel)" <peterz@...radead.org>
Subject: Re: [patch V6 12/37] x86/entry: Provide
 idtentry_entry/exit_cond_rcu()

On Thu, May 21, 2020 at 08:41:11PM +0200, Thomas Gleixner wrote:
> "Paul E. McKenney" <paulmck@...nel.org> writes:
> > On Thu, May 21, 2020 at 10:31:11AM +0200, Thomas Gleixner wrote:
> >> And I made this a NOP for for !NOHZ_FULL systems and avoided the call if
> >> context tracking is not enabled at boot.
> >> 
> >> void __rcu_irq_enter_check_tick(void);
> >> 
> >> static inline void rcu_irq_enter_check_tick(void)
> >> {
> >> 	if (context_tracking_enabled())
> >>         	__rcu_irq_enter_check_tick();
> >> }
> >
> > That certainly is a better approach!
> >
> > So let's go with your version.  But could you please post it, just in
> > case reviewing an alternative version causes me to spot something?
> 
> I'm just testing the complete rework of this series and will post it if
> it survives smoke testing.

Fair enough!

							Thanx, Paul