linux-kernel - Re: [PATCH V2 net-next 0/2] net: hns3: adds two VLAN feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200521121707.6499ca6b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 21 May 2020 12:17:07 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Huazhong Tan <tanhuazhong@...wei.com>
Cc:     <davem@...emloft.net>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <salil.mehta@...wei.com>,
        <yisen.zhuang@...wei.com>, <linuxarm@...wei.com>
Subject: Re: [PATCH V2 net-next 0/2] net: hns3: adds two VLAN feature

On Thu, 21 May 2020 19:38:23 +0800 Huazhong Tan wrote:
> This patchset adds two new VLAN feature.
> 
> [patch 1] adds a new dynamic VLAN mode.
> [patch 2] adds support for 'QoS' field to PVID.
> 
> Change log:
> V1->V2: modifies [patch 1]'s commit log, suggested by Jakub Kicinski.

I don't like the idea that FW is choosing the driver behavior in a way
that's not observable via standard Linux APIs. This is the second time
a feature like that posted for a driver this week, and we should
discourage it.