linux-kernel - RE: [PATCH 2/2] soundwire: intel: transition to 3 steps initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM6PR11MB407456180646DCCD9A962FC3FFB70@DM6PR11MB4074.namprd11.prod.outlook.com>
Date:   Thu, 21 May 2020 05:09:45 +0000
From:   "Liao, Bard" <bard.liao@...el.com>
To:     Vinod Koul <vkoul@...nel.org>
CC:     Bard Liao <yung-chuan.liao@...ux.intel.com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "tiwai@...e.de" <tiwai@...e.de>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "jank@...ence.com" <jank@...ence.com>,
        "srinivas.kandagatla@...aro.org" <srinivas.kandagatla@...aro.org>,
        "rander.wang@...ux.intel.com" <rander.wang@...ux.intel.com>,
        "ranjani.sridharan@...ux.intel.com" 
        <ranjani.sridharan@...ux.intel.com>,
        "hui.wang@...onical.com" <hui.wang@...onical.com>,
        "pierre-louis.bossart@...ux.intel.com" 
        <pierre-louis.bossart@...ux.intel.com>,
        "Kale, Sanyog R" <sanyog.r.kale@...el.com>,
        "Blauciak, Slawomir" <slawomir.blauciak@...el.com>,
        "Lin, Mengdong" <mengdong.lin@...el.com>
Subject: RE: [PATCH 2/2] soundwire: intel: transition to 3 steps
 initialization

> -----Original Message-----
> From: Vinod Koul <vkoul@...nel.org>
> Sent: Thursday, May 21, 2020 12:37 PM
> To: Liao, Bard <bard.liao@...el.com>
> Cc: Bard Liao <yung-chuan.liao@...ux.intel.com>; alsa-devel@...a-project.org;
> linux-kernel@...r.kernel.org; tiwai@...e.de; broonie@...nel.org;
> gregkh@...uxfoundation.org; jank@...ence.com;
> srinivas.kandagatla@...aro.org; rander.wang@...ux.intel.com;
> ranjani.sridharan@...ux.intel.com; hui.wang@...onical.com; pierre-
> louis.bossart@...ux.intel.com; Kale, Sanyog R <sanyog.r.kale@...el.com>;
> Blauciak, Slawomir <slawomir.blauciak@...el.com>; Lin, Mengdong
> <mengdong.lin@...el.com>
> Subject: Re: [PATCH 2/2] soundwire: intel: transition to 3 steps initialization
> 
> On 21-05-20, 02:23, Liao, Bard wrote:
> > > -----Original Message-----
> > > From: Vinod Koul <vkoul@...nel.org>
> > > Sent: Wednesday, May 20, 2020 9:54 PM
> > > To: Bard Liao <yung-chuan.liao@...ux.intel.com>
> > > Cc: alsa-devel@...a-project.org; linux-kernel@...r.kernel.org;
> > > tiwai@...e.de; broonie@...nel.org; gregkh@...uxfoundation.org;
> > > jank@...ence.com; srinivas.kandagatla@...aro.org;
> > > rander.wang@...ux.intel.com; ranjani.sridharan@...ux.intel.com;
> > > hui.wang@...onical.com; pierre- louis.bossart@...ux.intel.com; Kale,
> > > Sanyog R <sanyog.r.kale@...el.com>; Blauciak, Slawomir
> > > <slawomir.blauciak@...el.com>; Lin, Mengdong
> > > <mengdong.lin@...el.com>; Liao, Bard <bard.liao@...el.com>
> > > Subject: Re: [PATCH 2/2] soundwire: intel: transition to 3 steps
> > > initialization
> > >
> > > On 20-05-20, 03:19, Bard Liao wrote:
> > > > From: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
> > > >
> > > > Rather than a plain-vanilla init/exit, this patch provides 3 steps
> > > > in the initialization (ACPI scan, probe, startup) which makes it
> > > > easier to detect platform support for SoundWire, allocate required
> > > > resources as early as possible, and conversely help make the
> > > > startup() callback lighter-weight with only hardware register setup.
> > >
> > > Okay but can you add details in changelog on what each step would do?
> >
> > Sure. Will do.
> >
> > >
> > > > @@ -1134,25 +1142,15 @@ static int intel_probe(struct
> > > > platform_device
> > > *pdev)
> > > >
> > > >  	intel_pdi_ch_update(sdw);
> > > >
> > > > -	/* Acquire IRQ */
> > > > -	ret = request_threaded_irq(sdw->link_res->irq,
> > > > -				   sdw_cdns_irq, sdw_cdns_thread,
> > > > -				   IRQF_SHARED, KBUILD_MODNAME, &sdw-
> > > >cdns);
> > >
> > > This is removed here but not added anywhere else, do we have no irq
> > > after this patch?
> >
> > We use a single irq for all Intel Audio DSP events and it will be
> > requested in the SOF driver.
> 
> And how will the irq be propagated to sdw/cdns drivers here?

We export the handler and call it on SOF driver.

> 
> --
> ~Vinod