| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <OF1FE36FB9.9FBEFCD6-ON4825856F.002D767F-4825856F.002E7D42@mxic.com.tw>
Date: Thu, 21 May 2020 16:27:47 +0800
From: masonccyang@...c.com.tw
To: "Pratyush Yadav" <p.yadav@...com>
Cc: "Alexandre Belloni" <alexandre.belloni@...tlin.com>,
"Boris Brezillon" <boris.brezillon@...labora.com>,
"Mark Brown" <broonie@...nel.org>,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-mediatek@...ts.infradead.org, linux-mtd@...ts.infradead.org,
linux-spi@...r.kernel.org,
"Ludovic Desroches" <ludovic.desroches@...rochip.com>,
"Matthias Brugger" <matthias.bgg@...il.com>,
"Miquel Raynal" <miquel.raynal@...tlin.com>,
"Nicolas Ferre" <nicolas.ferre@...rochip.com>,
"Sekhar Nori" <nsekhar@...com>, "Pratyush Yadav" <p.yadav@...com>,
"Richard Weinberger" <richard@....at>,
"Tudor Ambarus" <tudor.ambarus@...rochip.com>,
"Vignesh Raghavendra" <vigneshr@...com>, juliensu@...c.com.tw
Subject: Re: [PATCH v5 01/19] spi: spi-mem: allow specifying whether an op is DTR or
not
Hi Pratyush,
Given cmd.nbytes a initial value & check it !
>
> [PATCH v5 01/19] spi: spi-mem: allow specifying whether an op is DTR or
not
>
> Each phase is given a separate 'dtr' field so mixed protocols like
> 4S-4D-4D can be supported.
>
> Signed-off-by: Pratyush Yadav <p.yadav@...com>
> ---
> drivers/spi/spi-mem.c | 3 +++
> include/linux/spi/spi-mem.h | 8 ++++++++
> 2 files changed, 11 insertions(+)
>
> diff --git a/drivers/spi/spi-mem.c b/drivers/spi/spi-mem.c
> index 9a86cc27fcc0..93e255287ab9 100644
> --- a/drivers/spi/spi-mem.c
> +++ b/drivers/spi/spi-mem.c
> @@ -156,6 +156,9 @@ bool spi_mem_default_supports_op(struct spi_mem
*mem,
> op->data.dir == SPI_MEM_DATA_OUT))
> return false;
>
> + if (op->cmd.dtr || op->addr.dtr || op->dummy.dtr || op->data.dtr)
> + return false;
> +
+ if (op->cmd.nbytes != 1)
+ return false;
> return true;
> }
> EXPORT_SYMBOL_GPL(spi_mem_default_supports_op);
static int spi_mem_check_op(const struct spi_mem_op *op)
{
- if (!op->cmd.buswidth)
+ if (!op->cmd.buswidth || op->cmd.nbytes < 1 ||
op->cmd.nbytes > 2)
return -EINVAL;
> diff --git a/include/linux/spi/spi-mem.h b/include/linux/spi/spi-mem.h
> index af9ff2f0f1b2..e3dcb956bf61 100644
> --- a/include/linux/spi/spi-mem.h
> +++ b/include/linux/spi/spi-mem.h
#define SPI_MEM_OP_CMD(__opcode, __buswidth) \
{ \
.buswidth = __buswidth, \
.opcode = __opcode, \
+ .nbytes = 1, \
}
> @@ -71,9 +71,11 @@ enum spi_mem_data_dir {
> * struct spi_mem_op - describes a SPI memory operation
> * @cmd.buswidth: number of IO lines used to transmit the command
> * @cmd.opcode: operation opcode
> + * @cmd.dtr: whether the command opcode should be sent in DTR mode or
not
> * @addr.nbytes: number of address bytes to send. Can be zero if the
operation
> * does not need to send an address
> * @addr.buswidth: number of IO lines used to transmit the address
cycles
> + * @addr.dtr: whether the address should be sent in DTR mode or not
> * @addr.val: address value. This value is always sent MSB first on the
bus.
> * Note that only @addr.nbytes are taken into account in this
> * address value, so users should make sure the value fits in
the
> @@ -81,7 +83,9 @@ enum spi_mem_data_dir {
> * @dummy.nbytes: number of dummy bytes to send after an opcode or
address. Can
> * be zero if the operation does not require dummy bytes
> * @dummy.buswidth: number of IO lanes used to transmit the dummy bytes
> + * @dummy.dtr: whether the dummy bytes should be sent in DTR mode or
not
> * @data.buswidth: number of IO lanes used to send/receive the data
> + * @data.dtr: whether the data should be sent in DTR mode or not
> * @data.dir: direction of the transfer
> * @data.nbytes: number of data bytes to send/receive. Can be zero if
the
> * operation does not involve transferring data
> @@ -91,22 +95,26 @@ enum spi_mem_data_dir {
> struct spi_mem_op {
> struct {
> u8 buswidth;
> + u8 dtr : 1;
> u8 opcode;
> } cmd;
>
> struct {
> u8 nbytes;
> u8 buswidth;
> + u8 dtr : 1;
> u64 val;
> } addr;
>
> struct {
> u8 nbytes;
> u8 buswidth;
> + u8 dtr : 1;
> } dummy;
>
> struct {
> u8 buswidth;
> + u8 dtr : 1;
> enum spi_mem_data_dir dir;
> unsigned int nbytes;
> union {
> --
> 2.26.2
>
thanks & best regards,
Mason
CONFIDENTIALITY NOTE:
This e-mail and any attachments may contain confidential information
and/or personal data, which is protected by applicable laws. Please be
reminded that duplication, disclosure, distribution, or use of this e-mail
(and/or its attachments) or any part thereof is prohibited. If you receive
this e-mail in error, please notify us immediately and delete this mail as
well as its attachment(s) from your system. In addition, please be
informed that collection, processing, and/or use of personal data is
prohibited unless expressly permitted by personal data protection laws.
Thank you for your attention and cooperation.
Macronix International Co., Ltd.
=====================================================================
============================================================================
CONFIDENTIALITY NOTE:
This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation.
Macronix International Co., Ltd.
=====================================================================
Powered by blists - more mailing lists