lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 21 May 2020 13:59:37 +0000
From:   Tomasz Figa <>
To:     Xia Jiang <>
Cc:     Hans Verkuil <>,
        Mauro Carvalho Chehab <>,
        Rob Herring <>,
        Matthias Brugger <>,
        Rick Chang <>,,,,,,
        Marek Szyprowski <>,,,,,,
Subject: Re: [PATCH v8 04/14] media: platform: Change the fixed device node
 number to unfixed value

Hi Xia,

On Fri, Apr 03, 2020 at 05:40:23PM +0800, Xia Jiang wrote:
> Change device node number from 3 to -1 because that the driver will
> also support jpeg encoder.

Thanks for the patch. The change is correct, but I think the commit
message doesn't really explain the real reason for it. Perhaps something

"The driver can be instantiated multiple times, e.g. for a decoder and
an encoder. Moreover, other drivers could coexist on the same system.
This makes the static video node number assignment pointless, so switch
to automatic assignment instead."


Best regards,

Powered by blists - more mailing lists