lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Fri, 22 May 2020 18:04:03 -0000
From:   "tip-bot2 for Josh Poimboeuf" <>
Cc:     Tetsuo Handa <>,
        Josh Poimboeuf <>,
        "Peter Zijlstra (Intel)" <>,
        x86 <>, LKML <>
Subject: [tip: x86/urgent] x86/unwind/orc: Fix unwind_get_return_address_ptr()
 for inactive tasks

The following commit has been merged into the x86/urgent branch of tip:

Commit-ID:     187b96db5ca79423618dfa29a05c438c34f9e1f0
Author:        Josh Poimboeuf <>
AuthorDate:    Fri, 22 May 2020 08:54:35 -05:00
Committer:     Peter Zijlstra <>
CommitterDate: Fri, 22 May 2020 19:55:17 +02:00

x86/unwind/orc: Fix unwind_get_return_address_ptr() for inactive tasks

Normally, show_trace_log_lvl() scans the stack, looking for text
addresses to print.  In parallel, it unwinds the stack with
unwind_next_frame().  If the stack address matches the pointer returned
by unwind_get_return_address_ptr() for the current frame, the text
address is printed normally without a question mark.  Otherwise it's
considered a breadcrumb (potentially from a previous call path) and it's
printed with a question mark to indicate that the address is unreliable
and typically can be ignored.

Since the following commit:

  f1d9a2abff66 ("x86/unwind/orc: Don't skip the first frame for inactive tasks")

... for inactive tasks, show_trace_log_lvl() prints *only* unreliable
addresses (prepended with '?').

That happens because, for the first frame of an inactive task,
unwind_get_return_address_ptr() returns the wrong return address
pointer: one word *below* the task stack pointer.  show_trace_log_lvl()
starts scanning at the stack pointer itself, so it never finds the first
'reliable' address, causing only guesses to being printed.

The first frame of an inactive task isn't a normal stack frame.  It's
actually just an instance of 'struct inactive_task_frame' which is left
behind by __switch_to_asm().  Now that this inactive frame is actually
exposed to callers, fix unwind_get_return_address_ptr() to interpret it

Fixes: f1d9a2abff66 ("x86/unwind/orc: Don't skip the first frame for inactive tasks")
Reported-by: Tetsuo Handa <>
Signed-off-by: Josh Poimboeuf <>
Signed-off-by: Peter Zijlstra (Intel) <>
 arch/x86/kernel/unwind_orc.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/x86/kernel/unwind_orc.c b/arch/x86/kernel/unwind_orc.c
index fa79e42..7f969b2 100644
--- a/arch/x86/kernel/unwind_orc.c
+++ b/arch/x86/kernel/unwind_orc.c
@@ -320,12 +320,19 @@ EXPORT_SYMBOL_GPL(unwind_get_return_address);
 unsigned long *unwind_get_return_address_ptr(struct unwind_state *state)
+	struct task_struct *task = state->task;
 	if (unwind_done(state))
 		return NULL;
 	if (state->regs)
 		return &state->regs->ip;
+	if (task != current && state->sp == task->thread.sp) {
+		struct inactive_task_frame *frame = (void *)task->thread.sp;
+		return &frame->ret_addr;
+	}
 	if (state->sp)
 		return (unsigned long *)state->sp - 1;

Powered by blists - more mailing lists