linux-kernel - Re: linux-next: Tree for May 18 (input/misc/iqs269a.c & regmap)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e6a56505-b99c-6b22-c35a-3596857fa421@infradead.org>
Date:   Fri, 22 May 2020 11:22:39 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Jeff LaBundy <jeff@...undy.com>
Cc:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        Mark Brown <broonie@...nel.org>
Subject: Re: linux-next: Tree for May 18 (input/misc/iqs269a.c & regmap)

On 5/18/20 9:20 AM, Jeff LaBundy wrote:
> Hi Randy et al,
> 
> On Mon, May 18, 2020 at 08:42:43AM -0700, Randy Dunlap wrote:
>> On 5/18/20 3:57 AM, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Changes since 20200515:
>>>
>>
>> on i386:
>>
>>
>> CONFIG_REGMAP_I2C=y
>> CONFIG_I2C=m
>>
>> WARNING: unmet direct dependencies detected for REGMAP_I2C
>>   Depends on [m]: I2C [=m]
>>   Selected by [y]:
>>   - INPUT_IQS269A [=y] && !UML && INPUT [=y] && INPUT_MISC [=y]
>>
>>
>> ld: drivers/base/regmap/regmap-i2c.o: in function `regmap_smbus_byte_reg_read':
>> regmap-i2c.c:(.text+0x192): undefined reference to `i2c_smbus_read_byte_data'
>> ld: drivers/base/regmap/regmap-i2c.o: in function `regmap_smbus_byte_reg_write':
>> regmap-i2c.c:(.text+0x1d7): undefined reference to `i2c_smbus_write_byte_data'
>> ld: drivers/base/regmap/regmap-i2c.o: in function `regmap_smbus_word_reg_read':
>> regmap-i2c.c:(.text+0x202): undefined reference to `i2c_smbus_read_word_data'
>> ld: drivers/base/regmap/regmap-i2c.o: in function `regmap_smbus_word_read_swapped':
>> regmap-i2c.c:(.text+0x242): undefined reference to `i2c_smbus_read_word_data'
>> ld: drivers/base/regmap/regmap-i2c.o: in function `regmap_smbus_word_write_swapped':
>> regmap-i2c.c:(.text+0x2a1): undefined reference to `i2c_smbus_write_word_data'
>> ld: drivers/base/regmap/regmap-i2c.o: in function `regmap_smbus_word_reg_write':
>> regmap-i2c.c:(.text+0x2d7): undefined reference to `i2c_smbus_write_word_data'
>> ld: drivers/base/regmap/regmap-i2c.o: in function `regmap_i2c_smbus_i2c_read_reg16':
>> regmap-i2c.c:(.text+0x310): undefined reference to `i2c_smbus_write_byte_data'
>> ld: regmap-i2c.c:(.text+0x323): undefined reference to `i2c_smbus_read_byte'
>> ld: drivers/base/regmap/regmap-i2c.o: in function `regmap_i2c_smbus_i2c_write_reg16':
>> regmap-i2c.c:(.text+0x39c): undefined reference to `i2c_smbus_write_i2c_block_data'
>> ld: drivers/base/regmap/regmap-i2c.o: in function `regmap_i2c_smbus_i2c_write':
>> regmap-i2c.c:(.text+0x3db): undefined reference to `i2c_smbus_write_i2c_block_data'
>> ld: drivers/base/regmap/regmap-i2c.o: in function `regmap_i2c_smbus_i2c_read':
>> regmap-i2c.c:(.text+0x427): undefined reference to `i2c_smbus_read_i2c_block_data'
>> ld: drivers/base/regmap/regmap-i2c.o: in function `regmap_i2c_read':
>> regmap-i2c.c:(.text+0x49f): undefined reference to `i2c_transfer'
>> ld: drivers/base/regmap/regmap-i2c.o: in function `regmap_i2c_gather_write':
>> regmap-i2c.c:(.text+0x524): undefined reference to `i2c_transfer'
>> ld: drivers/base/regmap/regmap-i2c.o: in function `regmap_i2c_write':
>> regmap-i2c.c:(.text+0x56c): undefined reference to `i2c_transfer_buffer_flags'
>> ld: drivers/input/misc/iqs269a.o: in function `iqs269_i2c_driver_init':
>> iqs269a.c:(.init.text+0xb): undefined reference to `i2c_register_driver'
>> ld: drivers/input/misc/iqs269a.o: in function `iqs269_i2c_driver_exit':
>> iqs269a.c:(.exit.text+0x9): undefined reference to `i2c_del_driver'
>>
>>
>>
>> Full randconfig file is attached.
> 
> A complete oversight on my part; during my testing I did not realize
> another module was selecting I2C for me. Valuable lesson learned :)
> 
> The kbuild test robot set off the alarm bells earlier today and I've
> sent a patch [1] already. Many apologies for all of the noise.
> 
>>
>> -- 
>> ~Randy
>> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> 
> [1] https://patchwork.kernel.org/patch/11555469/
> 
> Kind regards,
> Jeff LaBundy


Acked-by: Randy Dunlap <rdunlap@...radead.org> # build-tested


This build error still happens in linux-next 20200522.
Perhaps we can have this patch merged & pushed out so that
linux-next can pick it up, please?

thanks
-- 
~Randy