lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 22 May 2020 22:26:09 +0300 From: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com> To: Sean Christopherson <sean.j.christopherson@...el.com> Cc: linux-kernel@...r.kernel.org, x86@...nel.org, linux-sgx@...r.kernel.org, akpm@...ux-foundation.org, dave.hansen@...el.com, nhorman@...hat.com, npmccallum@...hat.com, haitao.huang@...el.com, andriy.shevchenko@...ux.intel.com, tglx@...utronix.de, kai.svahn@...el.com, bp@...en8.de, josh@...htriplett.org, luto@...nel.org, kai.huang@...el.com, rientjes@...gle.com, cedric.xing@...el.com, puiterwijk@...hat.com, linux-security-module@...r.kernel.org, Suresh Siddha <suresh.b.siddha@...el.com>, Jethro Beekman <jethro@...tanix.com>, Haitao Huang <haitao.huang@...ux.intel.com>, Chunyang Hui <sanqian.hcy@...fin.com>, Jordan Hand <jorhand@...ux.microsoft.com>, Seth Moore <sethmo@...gle.com> Subject: Re: [PATCH v30 10/20] x86/sgx: Linux Enclave Driver On Thu, May 21, 2020 at 12:12:36PM -0700, Sean Christopherson wrote: > On Fri, May 15, 2020 at 03:44:00AM +0300, Jarkko Sakkinen wrote: > > +long sgx_ioctl(struct file *filep, unsigned int cmd, unsigned long arg) > > +{ > > + struct sgx_encl *encl = filep->private_data; > > + int ret, encl_flags; > > + > > + encl_flags = atomic_fetch_or(SGX_ENCL_IOCTL, &encl->flags); > > + if (encl_flags & SGX_ENCL_IOCTL) > > + return -EBUSY; > > + > > + if (encl_flags & SGX_ENCL_DEAD) > > + return -EFAULT; > > Returning immediately is wrong as it leaves SGX_ENCL_IOCTL set. This results > in the application seeing -EBUSY on future ioctls() instead of -EFAULT. Can be > fixed as below. Do you want me to send a formal patch on linux-sgx? I just rewrote the same thing. /Jarkko
Powered by blists - more mailing lists