linux-kernel - Re: [PATCH] soc: fsl: dpio: Prefer the CPU affine DPIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 22 May 2020 17:51:43 -0500
From:   Li Yang <leoyang.li@....com>
To:     Ioana Ciornei <ioana.ciornei@....com>
Cc:     lkml <linux-kernel@...r.kernel.org>,
        Roy Pledge <roy.pledge@....com>
Subject: Re: [PATCH] soc: fsl: dpio: Prefer the CPU affine DPIO

On Fri, Apr 24, 2020 at 6:52 AM Ioana Ciornei <ioana.ciornei@....com> wrote:
>
> From: Roy Pledge <roy.pledge@....com>
>
> Use the cpu affine DPIO unless there isn't one which can happen
> if less DPIOs than cores are assign to the kernel.
>
> Signed-off-by: Roy Pledge <roy.pledge@....com>
> Signed-off-by: Ioana Ciornei <ioana.ciornei@....com>

Applied for next.  Thanks.

Regards,
Leo

> ---
>  drivers/soc/fsl/dpio/dpio-service.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/soc/fsl/dpio/dpio-service.c b/drivers/soc/fsl/dpio/dpio-service.c
> index cd4f6410e8c2..f1080c7a3fe1 100644
> --- a/drivers/soc/fsl/dpio/dpio-service.c
> +++ b/drivers/soc/fsl/dpio/dpio-service.c
> @@ -58,7 +58,7 @@ static inline struct dpaa2_io *service_select_by_cpu(struct dpaa2_io *d,
>          * If cpu == -1, choose the current cpu, with no guarantees about
>          * potentially being migrated away.
>          */
> -       if (unlikely(cpu < 0))
> +       if (cpu < 0)
>                 cpu = smp_processor_id();
>
>         /* If a specific cpu was requested, pick it up immediately */
> @@ -70,6 +70,10 @@ static inline struct dpaa2_io *service_select(struct dpaa2_io *d)
>         if (d)
>                 return d;
>
> +       d = service_select_by_cpu(d, -1);
> +       if (d)
> +               return d;
> +
>         spin_lock(&dpio_list_lock);
>         d = list_entry(dpio_list.next, struct dpaa2_io, node);
>         list_del(&d->node);
> --
> 2.17.1
>