linux-kernel - Re: [PATCH] net: ethernet: stmmac: Enable interface clocks on probe for IPQ806x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200522.160723.1511383489001652430.davem@davemloft.net>
Date:   Fri, 22 May 2020 16:07:23 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     noodles@...th.li
Cc:     peppe.cavallaro@...com, alexandre.torgue@...com,
        joabreu@...opsys.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        adron@...ic.net, marcel@...wiler.com
Subject: Re: [PATCH] net: ethernet: stmmac: Enable interface clocks on
 probe for IPQ806x

From: Jonathan McDowell <noodles@...th.li>
Date: Thu, 21 May 2020 12:49:34 +0100

> The ipq806x_gmac_probe() function enables the PTP clock but not the
> appropriate interface clocks. This means that if the bootloader hasn't
> done so attempting to bring up the interface will fail with an error
> like:
> 
> [   59.028131] ipq806x-gmac-dwmac 37600000.ethernet: Failed to reset the dma
> [   59.028196] ipq806x-gmac-dwmac 37600000.ethernet eth1: stmmac_hw_setup: DMA engine initialization failed
> [   59.034056] ipq806x-gmac-dwmac 37600000.ethernet eth1: stmmac_open: Hw setup failed
> 
> This patch, a slightly cleaned up version of one posted by Sergey
> Sergeev in:
> 
> https://forum.openwrt.org/t/support-for-mikrotik-rb3011uias-rm/4064/257
> 
> correctly enables the clock; we have already configured the source just
> before this.
> 
> Tested on a MikroTik RB3011.
> 
> Signed-off-by: Jonathan McDowell <noodles@...th.li>

Applied, thanks.