linux-kernel - Re: [PATCH net-next v3 0/2] provide KAPI for SQI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200521.171815.1268044117965833956.davem@davemloft.net>
Date:   Thu, 21 May 2020 17:18:15 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     o.rempel@...gutronix.de
Cc:     andrew@...n.ch, f.fainelli@...il.com, hkallweit1@...il.com,
        kuba@...nel.org, corbet@....net, mkubecek@...e.cz,
        david@...tonic.nl, kernel@...gutronix.de,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        linux@...linux.org.uk, mkl@...gutronix.de, marex@...x.de,
        christian.herber@....com
Subject: Re: [PATCH net-next v3 0/2] provide KAPI for SQI 

From: Oleksij Rempel <o.rempel@...gutronix.de>
Date: Wed, 20 May 2020 08:29:13 +0200

> This patches are extending ethtool netlink interface to export Signal
> Quality Index (SQI). SQI provided by 100Base-T1 PHYs and can be used for
> cable diagnostic. Compared to a typical cable tests, this value can be
> only used after link is established.
> 
> changes v3:
> - rename __ethtool_get_sqi* to linkstate_get_sqi*. And move this
>   functions to the net/ethtool/linkstate.c
> - protect linkstate_get_sqi* with locking
> 
> changes v2:
> - use u32 instead of u8 for SQI
> - add SQI_MAX field and callbacks
> - some style fixes in the rst.
> - do not convert index to shifted index.

Series applied, thank you.