linux-kernel - Re: [PATCH] mm/gup: might_lock_read(mmap_sem) in get_user_pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200522011600.GJ28818@bombadil.infradead.org>
Date:   Thu, 21 May 2020 18:16:00 -0700
From:   Matthew Wilcox <willy@...radead.org>
To:     John Hubbard <jhubbard@...dia.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>, jgg@...pe.ca,
        Liam.Howlett@...cle.com, daniel.m.jordan@...cle.com,
        dave@...olabs.net, hughd@...gle.com, jglisse@...hat.com,
        ldufour@...ux.ibm.com, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org, peterz@...radead.org, rientjes@...gle.com,
        vbabka@...e.cz, walken@...gle.com, yinghan@...gle.com
Subject: Re: [PATCH] mm/gup: might_lock_read(mmap_sem) in
 get_user_pages_fast()

On Thu, May 21, 2020 at 06:04:43PM -0700, John Hubbard wrote:
> Instead of scattering these assertions across the drivers,
> do this assertion inside the core of get_user_pages_fast*()
> functions. That also includes pin_user_pages_fast*()
> routines.
> 
> Add a might_lock_read(mmap_sem) call to internal_get_user_pages_fast().
> 
> Suggested-by: Matthew Wilcox <willy@...radead.org>

Yup, this is exactly what I meant.  Feel free to transform this into
an Acked-by: or Reviewed-by: if that's the appropriate tag.

Thanks, John!