linux-kernel - Re: [PATCH v2 2/3] extcon: max14577: Add proper dt-compatible strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 22 May 2020 10:30:55 +0200
From:   Marek Szyprowski <m.szyprowski@...sung.com>
To:     Chanwoo Choi <cw00.choi@...sung.com>, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Krzysztof Kozlowski <krzk@...nel.org>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        MyungJoo Ham <myungjoo.ham@...sung.com>,
        Sebastian Reichel <sre@...nel.org>,
        Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH v2 2/3] extcon: max14577: Add proper dt-compatible
 strings

Hi Chanwoo,

On 22.05.2020 09:08, Chanwoo Choi wrote:
> On 5/22/20 3:48 PM, Marek Szyprowski wrote:
>> Add device tree compatible strings and create proper modalias structures
>> to let this driver load automatically if compiled as module, because
>> max14577 MFD driver creates MFD cells with such compatible strings.
>>
>> Signed-off-by: Marek Szyprowski <m.szyprowski@...sung.com>
>> ---
>> v2:
>> - added .of_match_table pointer
>> ---
>>   drivers/extcon/extcon-max14577.c | 10 ++++++++++
>>   1 file changed, 10 insertions(+)
>>
>> diff --git a/drivers/extcon/extcon-max14577.c b/drivers/extcon/extcon-max14577.c
>> index 32f663436e6e..03af678ddeba 100644
>> --- a/drivers/extcon/extcon-max14577.c
>> +++ b/drivers/extcon/extcon-max14577.c
>> @@ -782,9 +782,19 @@ static const struct platform_device_id max14577_muic_id[] = {
>>   };
>>   MODULE_DEVICE_TABLE(platform, max14577_muic_id);
>>   
>> +static const struct of_device_id of_max14577_muic_dt_match[] = {
>> +	{ .compatible = "maxim,max77836-muic",
>> +	  .data = (void *)MAXIM_DEVICE_TYPE_MAX77836, },
>> +	{ .compatible = "maxim,max14577-muic",
>> +	  .data = (void *)MAXIM_DEVICE_TYPE_MAX14577, },
>> +	{ },
> How about changing the order between max77836 and max14577 as already added structure
> like platform_device_id if there are no specific reason as following:?
>
>
> static const struct of_device_id of_max14577_muic_dt_match[] = {
> 	{ .compatible = "maxim,max14577-muic",
> 	  .data = (void *)MAXIM_DEVICE_TYPE_MAX14577, },
> 	{ .compatible = "maxim,max77836-muic",
> 	  .data = (void *)MAXIM_DEVICE_TYPE_MAX77836, },
> 	{ },

Sure. I will swap them and send updated patch. This order comes from 
drivers/power/supply/max14577_charger.c, which also lacks 
.of_match_table, so I will also fix it.

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland