linux-kernel - Re: [PATCH] mmc: Fix use after free in mmc_rpmb_chrdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <e5af0076-7386-c6d9-960a-1b6b29141bfe@web.de>
Date:   Fri, 22 May 2020 11:08:59 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Peng Hao <richard.peng@...o.com>, linux-mmc@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org,
        Chaotian Jing <chaotian.jing@...iatek.com>,
        Ulf Hansson <ulf.hansson@...aro.org>
Subject: Re: [PATCH] mmc: Fix use after free in mmc_rpmb_chrdev_release()

> This is caused by dereferencing 'rpmb' after put_device().

I suggest to improve also this change description.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=051143e1602d90ea71887d92363edd539d411de5#n151

How do you think about a wording variant like the following?

   The data structure member “rpmb->md” was passed to a call of
   the function “mmc_blk_put” after a call of the function “put_device”.
   Reorder these function calls to keep the data accesses consistent.

Would you like to add the tag “Fixes” to the commit message?

Regards,
Markus