linux-kernel - Re: [PATCH] taging: speakup: remove volatile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 22 May 2020 11:37:38 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     MugilRaj <dmugil2000@...il.com>
Cc:     devel@...verdev.osuosl.org, Kirk Reiser <kirk@...sers.ca>,
        speakup@...ux-speakup.org, linux-kernel@...r.kernel.org,
        Samuel Thibault <samuel.thibault@...-lyon.org>,
        Chris Brannon <chris@...-brannons.com>
Subject: Re: [PATCH] taging: speakup: remove volatile

On Fri, May 22, 2020 at 02:46:28PM +0530, MugilRaj wrote:
> fix checkpatch.pl warning, which is Use of volatile is usually wrong: see
> Documentation/process/volatile-considered-harmful.rst
> Signed-off-by: MugilRaj <dmugil2000@...il.com>

As Samuel said, you can't "just remove this", otherwise it would have
been done a long time ago, don't you think?

But for your next patch, you need to have a blank line before the
signed-off-by: line in order for it to be in a format the patch could be
merged in.

thanks,

greg k-h