lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 22 May 2020 11:43:59 +0100 From: Jon Hunter <jonathanh@...dia.com> To: Dinghao Liu <dinghao.liu@....edu.cn>, <kjlu@....edu> CC: Laxman Dewangan <ldewangan@...dia.com>, Vinod Koul <vkoul@...nel.org>, "Dan Williams" <dan.j.williams@...el.com>, Thierry Reding <thierry.reding@...il.com>, <dmaengine@...r.kernel.org>, <linux-tegra@...r.kernel.org>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] dmaengine: tegra210-adma: Fix runtime PM imbalance on error On 22/05/2020 08:58, Dinghao Liu wrote: > pm_runtime_get_sync() increments the runtime PM usage counter even > when it returns an error code. Thus a pairing decrement is needed on > the error handling path to keep the counter balanced. > > Signed-off-by: Dinghao Liu <dinghao.liu@....edu.cn> > --- > drivers/dma/tegra210-adma.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/dma/tegra210-adma.c b/drivers/dma/tegra210-adma.c > index c4ce5dfb149b..803e1f4d5dac 100644 > --- a/drivers/dma/tegra210-adma.c > +++ b/drivers/dma/tegra210-adma.c > @@ -658,6 +658,7 @@ static int tegra_adma_alloc_chan_resources(struct dma_chan *dc) > > ret = pm_runtime_get_sync(tdc2dev(tdc)); > if (ret < 0) { > + pm_runtime_put_sync(tdc2dev(tdc)); > free_irq(tdc->irq, tdc); > return ret; > } > There is another place in probe that needs to be fixed as well. Can you correct this while you are at it? Thanks Jon -- nvpublic
Powered by blists - more mailing lists