linux-kernel - Re: [PATCH] net: qrtr: Fix passing invalid reference to qrtr_local

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200521.170538.966530806675679298.davem@davemloft.net>
Date:   Thu, 21 May 2020 17:05:38 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     manivannan.sadhasivam@...aro.org
Cc:     kuba@...nel.org, bjorn.andersson@...aro.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH] net: qrtr: Fix passing invalid reference to
 qrtr_local_enqueue()

From: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Date: Tue, 19 May 2020 23:44:16 +0530

> Once the traversal of the list is completed with list_for_each_entry(),
> the iterator (node) will point to an invalid object. So passing this to
> qrtr_local_enqueue() which is outside of the iterator block is erroneous
> eventhough the object is not used.
> 
> So fix this by passing NULL to qrtr_local_enqueue().
> 
> Fixes: bdabad3e363d ("net: Add Qualcomm IPC router")
> Reported-by: kbuild test robot <lkp@...el.com>
> Reported-by: Julia Lawall <julia.lawall@...6.fr>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>

Applied and queued up for -stable, thanks.