[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <VE1PR04MB66388D5243509C8EBF4DE9EB89B40@VE1PR04MB6638.eurprd04.prod.outlook.com>
Date: Fri, 22 May 2020 02:26:52 +0000
From: Robin Gong <yibin.gong@....com>
To: Fabio Estevam <festevam@...il.com>
CC: Rob Herring <robh+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
Sascha Hauer <s.hauer@...gutronix.de>,
Anson Huang <anson.huang@....com>, Peng Fan <peng.fan@....com>,
Sascha Hauer <kernel@...gutronix.de>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@...r.kernel.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@...ts.infradead.org>,
linux-kernel <linux-kernel@...r.kernel.org>,
dl-linux-imx <linux-imx@....com>
Subject: RE: [PATCH v2 2/2] arm64: dts: imx8mn-ddr4-evk: correct ldo1/ldo2
voltage range
On 2020/05/22 Fabio Estevam <festevam@...il.com> wrote:
> Hi Robin,
>
> On Thu, May 21, 2020 at 3:17 AM Robin Gong <yibin.gong@....com> wrote:
> >
> > Correct ldo1 voltage range from wrong high group(3.0v~3.3v) to low
> > group
>
> Please use capital letter V for Volt.
>
> > (1.6v~1.9v) because the ldo1 should be 1.8v. Actually, two voltage
> > groups have been supported at bd718x7-regulator driver, hence, just
> > corrrect the voltage range to 1.6v~3.3v. For ldo2@...v, correct voltage range
> too.
> > Otherwise, ldo1 would be kept @3.0v and ldo2@...v which violate
> > i.mx8mn datasheet as the below warning log in kernel:
> >
> > [ 0.995524] LDO1: Bringing 1800000uV into 3000000-3000000uV
> > [ 0.999196] LDO2: Bringing 800000uV into 900000-900000uV
> >
> > Signed-off-by: Robin Gong <yibin.gong@....com>
>
> You should add a Fixes tag and Cc stable on this one.
Okay, will address your comments in v3, thanks.
Powered by blists - more mailing lists