lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 22 May 2020 10:51:41 -0400 From: Sasha Levin <sashal@...nel.org> To: linux-kernel@...r.kernel.org, stable@...r.kernel.org Cc: Steve French <stfrench@...rosoft.com>, Coverity <scan-admin@...erity.com>, Shyam Prasad N <nspmangalore@...il.com>, Sasha Levin <sashal@...nel.org>, linux-cifs@...r.kernel.org, samba-technical@...ts.samba.org Subject: [PATCH AUTOSEL 4.14 12/13] cifs: Fix null pointer check in cifs_read From: Steve French <stfrench@...rosoft.com> [ Upstream commit 9bd21d4b1a767c3abebec203342f3820dcb84662 ] Coverity scan noted a redundant null check Coverity-id: 728517 Reported-by: Coverity <scan-admin@...erity.com> Signed-off-by: Steve French <stfrench@...rosoft.com> Reviewed-by: Shyam Prasad N <nspmangalore@...il.com> Signed-off-by: Sasha Levin <sashal@...nel.org> --- fs/cifs/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/cifs/file.c b/fs/cifs/file.c index 662977b8d6ae..72e7cbfb325a 100644 --- a/fs/cifs/file.c +++ b/fs/cifs/file.c @@ -3496,7 +3496,7 @@ cifs_read(struct file *file, char *read_data, size_t read_size, loff_t *offset) * than it negotiated since it will refuse the read * then. */ - if ((tcon->ses) && !(tcon->ses->capabilities & + if (!(tcon->ses->capabilities & tcon->ses->server->vals->cap_large_files)) { current_read_size = min_t(uint, current_read_size, CIFSMaxBufSize); -- 2.25.1
Powered by blists - more mailing lists