linux-kernel - Re: [PATCH 05/11] mmc: sdio: Move SDIO IDs from btmtksdio driver to common include file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <804fbad7-11ba-8d8b-d58e-3eb4e5cf2b41@gmail.com>
Date:   Fri, 22 May 2020 17:02:11 +0200
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     Pali Rohár <pali@...nel.org>,
        Ulf Hansson <ulf.hansson@...aro.org>, linux-mmc@...r.kernel.org
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Kalle Valo <kvalo@...eaurora.org>,
        Amitkumar Karwar <amitkarwar@...il.com>,
        Ganapathi Bhat <ganapathi.bhat@....com>,
        Xinming Hu <huxinming820@...il.com>,
        linux-kernel@...r.kernel.org, ath10k@...ts.infradead.org,
        b43-dev@...ts.infradead.org, brcm80211-dev-list.pdl@...adcom.com,
        brcm80211-dev-list@...ress.com, libertas-dev@...ts.infradead.org,
        linux-wireless@...r.kernel.org,
        Marek Behún <marek.behun@....cz>,
        Sean Wang <sean.wang@...iatek.com>
Subject: Re: [PATCH 05/11] mmc: sdio: Move SDIO IDs from btmtksdio driver to
 common include file



On 22/05/2020 16:44, Pali Rohár wrote:
> Define appropriate macro names for consistency with other macros.
> 
> Signed-off-by: Pali Rohár <pali@...nel.org>

Reviewed-by: Matthias Brugger <matthias.bgg@...il.com>

> ---
>  drivers/bluetooth/btmtksdio.c | 4 ++--
>  include/linux/mmc/sdio_ids.h  | 2 ++
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/bluetooth/btmtksdio.c b/drivers/bluetooth/btmtksdio.c
> index 519788c442ca..bff095be2f97 100644
> --- a/drivers/bluetooth/btmtksdio.c
> +++ b/drivers/bluetooth/btmtksdio.c
> @@ -51,9 +51,9 @@ static const struct btmtksdio_data mt7668_data = {
>  };
>  
>  static const struct sdio_device_id btmtksdio_table[] = {
> -	{SDIO_DEVICE(SDIO_VENDOR_ID_MEDIATEK, 0x7663),
> +	{SDIO_DEVICE(SDIO_VENDOR_ID_MEDIATEK, SDIO_DEVICE_ID_MEDIATEK_MT7663),
>  	 .driver_data = (kernel_ulong_t)&mt7663_data },
> -	{SDIO_DEVICE(SDIO_VENDOR_ID_MEDIATEK, 0x7668),
> +	{SDIO_DEVICE(SDIO_VENDOR_ID_MEDIATEK, SDIO_DEVICE_ID_MEDIATEK_MT7668),
>  	 .driver_data = (kernel_ulong_t)&mt7668_data },
>  	{ }	/* Terminating entry */
>  };
> diff --git a/include/linux/mmc/sdio_ids.h b/include/linux/mmc/sdio_ids.h
> index 1237e1048d06..c9aca57d4dea 100644
> --- a/include/linux/mmc/sdio_ids.h
> +++ b/include/linux/mmc/sdio_ids.h
> @@ -80,6 +80,8 @@
>  #define SDIO_DEVICE_ID_MARVELL_8987_BT		0x914a
>  
>  #define SDIO_VENDOR_ID_MEDIATEK			0x037a
> +#define SDIO_DEVICE_ID_MEDIATEK_MT7663		0x7663
> +#define SDIO_DEVICE_ID_MEDIATEK_MT7668		0x7668
>  
>  #define SDIO_VENDOR_ID_SIANO			0x039a
>  #define SDIO_DEVICE_ID_SIANO_NOVA_B0		0x0201
>