linux-kernel - Re: [PATCH] i2c: drivers: Avoid unnecessary check in efm32_i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200522150738.GH5670@ninjato>
Date:   Fri, 22 May 2020 17:07:39 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Tang Bin <tangbin@...s.chinamobile.com>
Cc:     o.rempel@...gutronix.de, u.kleine-koenig@...gutronix.de,
        ardb@...nel.org, linux-i2c@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Shengju Zhang <zhangshengju@...s.chinamobile.com>
Subject: Re: [PATCH] i2c: drivers: Avoid unnecessary check in
 efm32_i2c_probe()

On Wed, Apr 15, 2020 at 10:06:40PM +0800, Tang Bin wrote:
> The function efm32_i2c_probe() is only called with an
> openfirmware platform device.Therefore there is no need
> to check that it has an openfirmware node.
> 
> Signed-off-by: Tang Bin <tangbin@...s.chinamobile.com>
> Signed-off-by: Shengju Zhang <zhangshengju@...s.chinamobile.com>

Applied to for-next, thanks! I agree the driver will need additions for
non-DT platforms anyhow, so greeting with an OOPS is kinda suitable, too
;)


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)