linux-kernel - Re: [PATCH] i2c: nvidia-gpu: Use PTR_ERR_OR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 22 May 2020 17:17:10 +0200
From:   Wolfram Sang <wsa@...nel.org>
To:     Aishwarya Ramakrishnan <aishwaryarj100@...il.com>
Cc:     Ajay Gupta <ajayg@...dia.com>, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: nvidia-gpu: Use PTR_ERR_OR_ZERO() to simplify code

On Tue, May 05, 2020 at 08:22:30PM +0530, Aishwarya Ramakrishnan wrote:
> PTR_ERR_OR_ZERO contains if(IS_ERR(...)) + PTR_ERR.
> 
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
> 
> Signed-off-by: Aishwarya Ramakrishnan <aishwaryarj100@...il.com>

Waiting for the Rev-by from Ajay (driver maintainer).

> ---
>  drivers/i2c/busses/i2c-nvidia-gpu.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-nvidia-gpu.c b/drivers/i2c/busses/i2c-nvidia-gpu.c
> index f5d25ce00f03..f480105000b8 100644
> --- a/drivers/i2c/busses/i2c-nvidia-gpu.c
> +++ b/drivers/i2c/busses/i2c-nvidia-gpu.c
> @@ -277,10 +277,7 @@ static int gpu_populate_client(struct gpu_i2c_dev *i2cd, int irq)
>  	i2cd->gpu_ccgx_ucsi->irq = irq;
>  	i2cd->gpu_ccgx_ucsi->properties = ccgx_props;
>  	i2cd->ccgx_client = i2c_new_client_device(&i2cd->adapter, i2cd->gpu_ccgx_ucsi);
> -	if (IS_ERR(i2cd->ccgx_client))
> -		return PTR_ERR(i2cd->ccgx_client);
> -
> -	return 0;
> +	return PTR_ERR_OR_ZERO(i2cd->ccgx_client);
>  }
>  
>  static int gpu_i2c_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> -- 
> 2.17.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)