linux-kernel - Re: [PATCH v2] i2c: cadence: Add an error handling for platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7763d79e-3a44-2dbe-a4d3-45d40a3a1e02@xilinx.com>
Date:   Fri, 22 May 2020 17:26:40 +0200
From:   Michal Simek <michal.simek@...inx.com>
To:     Wolfram Sang <wsa@...-dreams.de>,
        Michal Simek <michal.simek@...inx.com>
Cc:     Dejin Zheng <zhengdejin5@...il.com>, harinik@...inx.com,
        soren.brinkmann@...inx.com, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] i2c: cadence: Add an error handling for
 platform_get_irq()

On 22. 05. 20 17:14, Wolfram Sang wrote:
> 
>> The change is valid but the question is if make sense to do it in this
>> way. Some drivers are using devm_request_irq to do do job.
>>
>> For example:
>>  	id->irq = platform_get_irq(pdev, 0);
>>         ret = devm_request_irq(&pdev->dev, id->irq, cdns_i2c_isr, 0,
>>                                   DRIVER_NAME, id);
>>         if (ret)
>> 		return ret;
> 
> I like this version better. Maybe we should simply move the
> platform_get_irq() line to the devm_request_irq() call?

You know about
devm_platform_get_and_ioremap_resource()
usage.
 Maybe that's the way to go. Because as of today there is no way to pass
position of irq resource.

But I expect it will come in near future.

Thanks,
Michal