linux-kernel - Re: [PATCH] [v3] usb: musb: Fix runtime PM imbalance on error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 22 May 2020 10:37:01 -0500
From:   Bin Liu <b-liu@...com>
To:     Dinghao Liu <dinghao.liu@....edu.cn>
CC:     <kjlu@....edu>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] [v3] usb: musb: Fix runtime PM imbalance on error

On Fri, May 22, 2020 at 01:42:35PM +0800, Dinghao Liu wrote:
> When copy_from_user() returns an error code, there
> is a runtime PM usage counter imbalance.
> 
> Fix this by moving copy_from_user() to the beginning
> of this function.
> 
> Signed-off-by: Dinghao Liu <dinghao.liu@....edu.cn>
> ---
> 
> Changelog:
> 
> v2: - Move copy_from_user() to the beginning rather
>       than adding pm_runtime_put_autosuspend().
> 
> v3: - Add missing changelog information.

Queued for v5.8. Thanks.
-Bin.