linux-kernel - Re: drivers/ide/ide-ioctls.c:15:24: sparse: sparse: incorrect type in initializer (different address spaces)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200522153953.GR23230@ZenIV.linux.org.uk>
Date:   Fri, 22 May 2020 16:39:53 +0100
From:   Al Viro <viro@...iv.linux.org.uk>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     kbuild test robot <lkp@...el.com>, kbuild-all@...ts.01.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Ben Hutchings <bwh@...nel.org>,
        Chris Zankel <chris@...kel.net>,
        Max Filippov <jcmvbkbc@...il.com>,
        linux-xtensa@...ux-xtensa.org
Subject: Re: drivers/ide/ide-ioctls.c:15:24: sparse: sparse: incorrect type
 in initializer (different address spaces)

On Fri, May 22, 2020 at 03:40:50PM +0200, Arnd Bergmann wrote:
> On Fri, May 22, 2020 at 2:24 PM kbuild test robot <lkp@...el.com> wrote:
> >
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > head:   051143e1602d90ea71887d92363edd539d411de5
> > commit: 1df23c6fe5b0654ece219985a0c32e40b100bd9a compat_ioctl: move HDIO ioctl handling into drivers/ide
> > date:   5 months ago
> > config: xtensa-randconfig-s002-20200522 (attached as .config)
> > compiler: xtensa-linux-gcc (GCC) 9.3.0
> > reproduce:
> >         # apt-get install sparse
> >         # sparse version: v0.6.1-193-gb8fad4bc-dirty
> >         git checkout 1df23c6fe5b0654ece219985a0c32e40b100bd9a
> >         # save the attached .config to linux build tree
> >         make W=1 C=1 ARCH=xtensa CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kbuild test robot <lkp@...el.com>
> >
> >
> > sparse warnings: (new ones prefixed by >>)
> >
> >    ./arch/xtensa/include/generated/uapi/asm/unistd_32.h:391:41: sparse: sparse: no newline at end of file
> > >> drivers/ide/ide-ioctls.c:15:24: sparse: sparse: incorrect type in initializer (different address spaces) @@    expected signed int *__pu_addr @@    got signed int [noderef] [usertypsigned int *__pu_addr @@
> > >> drivers/ide/ide-ioctls.c:15:24: sparse:    expected signed int *__pu_addr
> > >> drivers/ide/ide-ioctls.c:15:24: sparse:    got signed int [noderef] [usertype] <asn:1> *
> > >> drivers/ide/ide-ioctls.c:15:24: sparse: sparse: incorrect type in argument 1 (different address spaces) @@    expected void [noderef] <asn:1> *to @@    got f] <asn:1> *to @@
> >    drivers/ide/ide-ioctls.c:15:24: sparse:    expected void [noderef] <asn:1> *to
> > >> drivers/ide/ide-ioctls.c:15:24: sparse:    got signed int *__pu_addr
> 
> 
> I think this is a bug in the xtensa asm/uaccess.h, but I don't know why it
> only showed up now.

xtensa has no __user annotations in there.  At all.  So until somebody sits
down and does those, there will be such noise, reported every time somebody
changes a line with get_user() or put_user() anywhere in the tree.

As far as I'm concerned, __user-related reports on xtensa are to be ignored
for now.