linux-kernel - Re: [RFC PATCH 1/2] debug: Convert dbg_slave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200522162647.GW317569@hirez.programming.kicks-ass.net>
Date:   Fri, 22 May 2020 18:26:47 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Daniel Thompson <daniel.thompson@...aro.org>
Cc:     sumit.garg@...aro.org, jason.wessel@...driver.com,
        dianders@...omium.org, kgdb-bugreport@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org, patches@...aro.org, pmladek@...e.com,
        sergey.senozhatsky@...il.com, Ingo Molnar <mingo@...hat.com>,
        Will Deacon <will@...nel.org>
Subject: Re: [RFC PATCH 1/2] debug: Convert dbg_slave_lock to an atomic

On Fri, May 22, 2020 at 03:55:09PM +0100, Daniel Thompson wrote:

> +static atomic_t			slaves_must_spin;

> +			if (!atomic_read(&slaves_must_spin))

> +		atomic_set(&slaves_must_spin, 1);

> +		atomic_set(&slaves_must_spin, 0);

There is no atomic operation there; this is pointless use of atomic_t.