linux-kernel - Re: Re: Re: Re: [PATCH] spi: tegra20-slink: Fix runtime PM imbalance on error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 23 May 2020 20:04:29 +0800 (GMT+08:00)
From:   dinghao.liu@....edu.cn
To:     "Andy Shevchenko" <andy.shevchenko@...il.com>
Cc:     "Kangjie Lu" <kjlu@....edu>,
        "Laxman Dewangan" <ldewangan@...dia.com>,
        "Mark Brown" <broonie@...nel.org>,
        "Thierry Reding" <thierry.reding@...il.com>,
        "Jonathan Hunter" <jonathanh@...dia.com>,
        linux-spi <linux-spi@...r.kernel.org>,
        linux-tegra@...r.kernel.org,
        "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>
Subject: Re: Re: Re: Re: [PATCH] spi: tegra20-slink: Fix runtime PM
 imbalance on error

> On Sat, May 23, 2020 at 2:32 PM <dinghao.liu@....edu.cn> wrote:
> >
> > > On Fri, May 22, 2020 at 6:20 PM Andy Shevchenko
> > > <andy.shevchenko@...il.com> wrote:
> > > > On Fri, May 22, 2020 at 10:46 AM <dinghao.liu@....edu.cn> wrote:
> 
> ...
> 
> > I also checked many other implementation of probe in drivers.
> > It seems that using pm_runtime_put() is ok.
> 
> In *error path* or normal path?
> 

Error path (e.g., sysc_probe, exynos_trng_probe, 
map_rng_probe, ti_eqep_probe).

> > If I misunderstood
> > your opinion, please point it out, thanks.
> 
> Bottom line is (for the *error path* case):
> pm_runtime_put_noidle() has no side effects
> pm_runtime_put() (potentially) might have side effects.
> 
> You should choose one which is clearer about what it does.
> 
> -- 
> With Best Regards,
> Andy Shevchenko

Agree, for this bug using _noidle() is clearer. I will 
send a new path to fix this.

Regards,
Dinghao