linux-kernel - Re: [PATCH] linux/blkdev.h: Use ilog2() directly in blksize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <98a69358-9976-e0e6-9cc6-f9c4676d8f3f@kernel.dk>
Date:   Sat, 23 May 2020 11:07:32 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Kaitao Cheng <pilgrimtao@...il.com>
Cc:     damien.lemoal@....com, bvanassche@....org, ming.lei@...hat.com,
        martin.petersen@...cle.com, satyat@...gle.com,
        chaitanya.kulkarni@....com, houtao1@...wei.com,
        asml.silence@...il.com, ajay.joshi@....com,
        linux-kernel@...r.kernel.org, songmuchun@...edance.com
Subject: Re: [PATCH] linux/blkdev.h: Use ilog2() directly in blksize_bits()

On 5/23/20 9:50 AM, Kaitao Cheng wrote:
> blksize_bits() can be achieved through ilog2(), and ilog2() is
> more efficient.

I like the simplification, but do you have any results to back up
that claim? Is the generated code shorter? Runs faster?

-- 
Jens Axboe