linux-kernel - Re: [PATCH] linux/blkdev.h: Use ilog2() directly in blksize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fd3b8124-d62b-ca73-5af2-0d2ee2c58f92@kernel.dk>
Date:   Sat, 23 May 2020 12:50:03 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Bart Van Assche <bvanassche@....org>,
        Kaitao Cheng <pilgrimtao@...il.com>
Cc:     damien.lemoal@....com, ming.lei@...hat.com,
        martin.petersen@...cle.com, satyat@...gle.com,
        chaitanya.kulkarni@....com, houtao1@...wei.com,
        asml.silence@...il.com, ajay.joshi@....com,
        linux-kernel@...r.kernel.org, songmuchun@...edance.com
Subject: Re: [PATCH] linux/blkdev.h: Use ilog2() directly in blksize_bits()

On 5/23/20 12:33 PM, Bart Van Assche wrote:
> On 2020-05-23 08:50, Kaitao Cheng wrote:
>> blksize_bits() can be achieved through ilog2(), and ilog2() is
>> more efficient.
> 
> If Jens agrees, how about removing the blksize_bits() function entirely
> and to make all callers use ilog2() instead of blksize_bits()?

Yeah, if we are going this path, then let's just kill the function
completely.

-- 
Jens Axboe