lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 24 May 2020 00:41:32 +0200 From: Peter Zijlstra <peterz@...radead.org> To: "Sebastian A. Siewior" <bigeasy@...utronix.de> Cc: "Ahmed S. Darwish" <a.darwish@...utronix.de>, Ingo Molnar <mingo@...hat.com>, Will Deacon <will@...nel.org>, Thomas Gleixner <tglx@...utronix.de>, "Paul E. McKenney" <paulmck@...nel.org>, Steven Rostedt <rostedt@...dmis.org>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v1 07/25] lockdep: Add preemption disabled assertion API On Sat, May 23, 2020 at 04:59:42PM +0200, Sebastian A. Siewior wrote: > On 2020-05-22 19:55:03 [+0200], Peter Zijlstra wrote: > > That is both more consistent with the things you claim it's modelled > > after and also completely avoids that header dependency. > > So we need additionally: > > - #include <linux/sched.h> in include/linux/flex_proportions.h > and I think un another file as well. > > - write_seqcount_t_begin_nested() as a define > > - write_seqcount_t_begin() as a define > > Any "static inline" in the header file using > lockdep_assert_preemption_disabled() will tro to complain about missing > current-> define. But yes, it will work otherwise. Because...? /me rummages around.. Ah you're proposing sticking this in seqcount itself and then header hell. Moo.. ok I'll go have another look on Monday.
Powered by blists - more mailing lists