linux-kernel - Re: [PATCH v2 0/5] net: provide a devres variant of register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200523.165632.2131763470920616688.davem@davemloft.net>
Date:   Sat, 23 May 2020 16:56:32 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     brgl@...ev.pl
Cc:     corbet@....net, matthias.bgg@...il.com, john@...ozen.org,
        sean.wang@...iatek.com, Mark-MC.Lee@...iatek.com, kuba@...nel.org,
        arnd@...db.de, fparent@...libre.com, hkallweit1@...il.com,
        edwin.peer@...adcom.com, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org,
        stephane.leprovost@...iatek.com, pedro.tsai@...iatek.com,
        andrew.perepech@...iatek.com, bgolaszewski@...libre.com
Subject: Re: [PATCH v2 0/5] net: provide a devres variant of
 register_netdev()

From: Bartosz Golaszewski <brgl@...ev.pl>
Date: Sat, 23 May 2020 15:27:06 +0200

> From: Bartosz Golaszewski <bgolaszewski@...libre.com>
> 
> Using devres helpers allows to shrink the probing code, avoid memory leaks in
> error paths make sure the order in which resources are freed is the exact
> opposite of their allocation. This series proposes to add a devres variant
> of register_netdev() that will only work with net_device structures whose
> memory is also managed.
> 
> First we add the missing documentation entry for the only other networking
> devres helper: devm_alloc_etherdev().
> 
> Next we move devm_alloc_etherdev() into a separate source file.
> 
> We then use a proxy structure in devm_alloc_etherdev() to improve readability.
> 
> Last: we implement devm_register_netdev() and use it in mtk-eth-mac driver.
> 
> v1 -> v2:
> - rebase on top of net-next after driver rename, no functional changes

Series applied, thank you.