linux-kernel - Re: [PATCH] printk: Remove pr_cont

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 24 May 2020 11:49:34 -0700
From:   Joe Perches <joe@...ches.com>
To:     Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Petr Mladek <pmladek@...e.com>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Steven Rostedt <rostedt@...dmis.org>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] printk: Remove pr_cont_once()

On Mon, 2020-05-25 at 00:32 +0900, Tetsuo Handa wrote:
> pr_cont_once() does not make sense; at least emitting module name using
> pr_fmt() into middle of a line (after e.g. pr_info_once()) does not make
> sense. Let's remove unused pr_cont_once().

Right, thanks.

It's nearly a decade old cut'n'paste defect and
no one has ever used it or noticed it until now.

> Signed-off-by: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
> Cc: Joe Perches <joe@...ches.com>
> ---
>  include/linux/printk.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/include/linux/printk.h b/include/linux/printk.h
> index 2562ffb438ed..4c565871f659 100644
> --- a/include/linux/printk.h
> +++ b/include/linux/printk.h
> @@ -476,8 +476,7 @@ extern int kptr_restrict;
>  	printk_once(KERN_NOTICE pr_fmt(fmt), ##__VA_ARGS__)
>  #define pr_info_once(fmt, ...)					\
>  	printk_once(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
> -#define pr_cont_once(fmt, ...)					\
> -	printk_once(KERN_CONT pr_fmt(fmt), ##__VA_ARGS__)
> +/* no pr_cont_once, don't do that... */
>  
>  #if defined(DEBUG) || defined(CONFIG_TWIST_ALWAYS_EVALUATE_DEBUG_PRINTK)
>  #define pr_devel_once(fmt, ...)					\