linux-kernel - Re: [PATCH V2] media: s3c-camif: fix missing disable in tegra_adma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9b1cdd76-1fbf-c66b-a8e1-929ce2aba791@kernel.org>
Date:   Sun, 24 May 2020 21:03:23 +0200
From:   Sylwester Nawrocki <snawrocki@...nel.org>
To:     wu000273@....edu
Cc:     mchehab@...nel.org, linux-media@...r.kernel.org,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
        kjlu@....edu
Subject: Re: [PATCH V2] media: s3c-camif: fix missing disable in
 tegra_adma_probe().

Hi,

On 5/24/20 05:46, wu000273@....edu wrote:
> From: Qiushi Wu <wu000273@....edu>
> 
> "pm_runtime_enable()" was not handled by "pm_runtime_disable()"
> after a call of the function “pm_runtime_get_sync()” failed.
> Thus move the jump target “err_pm” before calling function
> "calling pm_runtime_disable()".
> 
> Fixes: babde1c243b2 ("[media] V4L: Add driver for S3C24XX/S3C64XX SoC series camera interface")
> Signed-off-by: Qiushi Wu <wu000273@....edu>
> ---
> 
> V2: improving commit messages.

Thanks for the patch. It seems you have got typo in the subject line.
With tegra_adma_probe changed to s3c_camif_probe feel free to add:

Reviewed-by: Sylwester Nawrocki <s.nawrocki@...sung.com>