linux-kernel - Re: [PATCH 1/1] soc: keembay: Add Keem Bay IMR driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200524212851.GG1192@bug>
Date:   Sun, 24 May 2020 23:28:51 +0200
From:   Pavel Machek <pavel@....cz>
To:     Daniele Alessandrelli <daniele.alessandrelli@...ux.intel.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, Rob Herring <robh@...nel.org>,
        Andy Shevchenko <andriy.shevchenko@...el.com>,
        Paul J Murphy <paul.j.murphy@...el.com>,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH 1/1] soc: keembay: Add Keem Bay IMR driver

Hi!

> > Like I said above, you just broke multi-system kernels by always
> > trying
> > to do this.  Trigger off of a hardware device that only your platform
> > has in order to properly load and run.  As-is, you don't want to do
> > this.
> 
> My bad, I didn't consider the issue of multi-platform ARM kernels.
> 
> The problem is that I need this code to be run early at boot, so I
> don't think I can make this a module.

How early is early enough?

What bootloader are you using?

I believe you should simply fix your bootloader not to pass locked memory to the kernel.

Alternatively, take that memory off the "memory available" maps, and only re-add it once
it is usable.

Anything else is dangerous.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html