lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 24 May 2020 09:00:28 +0200 From: Markus Elfring <Markus.Elfring@....de> To: Dejin Zheng <zhengdejin5@...il.com>, linux-i2c@...r.kernel.org, kernel-janitors@...r.kernel.org Cc: Ard Biesheuvel <ardb@...nel.org>, Barry Song <baohua@...nel.org>, Baruch Siach <baruch@...s.co.il>, Fabio Estevam <festevam@...il.com>, Florian Fainelli <f.fainelli@...il.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Heiko Stübner <heiko@...ech.de>, Kevin Hilman <khilman@...libre.com>, Linus Walleij <linus.walleij@...aro.org>, Michal Simek <michal.simek@...inx.com>, Paul Cercueil <paul@...pouillou.net>, "Rafael J. Wysocki" <rafael@...nel.org>, Ray Jui <rjui@...adcom.com>, Scott Branden <sbranden@...adcom.com>, Shawn Guo <shawnguo@...nel.org>, Vladimir Zapolskiy <vz@...ia.com>, Wolfram Sang <wsa@...-dreams.de>, linux-kernel@...r.kernel.org, Coccinelle <cocci@...teme.lip6.fr> Subject: Re: [PATCH v2 1/2] drivers: provide devm_platform_request_irq() > It will call devm_request_irq() after platform_get_irq() function > in many drivers, sometimes, it is not right for the error handling > of these two functions in some drivers. so provide this function > to simplify the driver. I recommend to improve also this change description. How do you think about a wording variant like the following? The function “devm_request_irq” is called after the function “platform_get_irq” in many drivers. The exception handling is incomplete there sometimes. Thus add a corresponding wrapper function for the simplification of the drivers. Will a companion script for the semantic patch language (Coccinelle software) become helpful for further support of collateral evolution? Regards, Markus
Powered by blists - more mailing lists