linux-kernel - Re: [PATCH] proc/fd: Remove the initialization of variables in seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 24 May 2020 09:46:50 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Kaitao Cheng <pilgrimtao@...il.com>, linux-fsdevel@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Alexey Dobriyan <adobriyan@...il.com>,
        Muchun Song <songmuchun@...edance.com>
Subject: Re: [PATCH] proc/fd: Remove the initialization of variables in
 seq_show()

> The variables{files, file} will definitely be assigned,

I find an other specification nicer for these identifiers.

> so we don't need to initialize them.

I suggest to recheck programming concerns around the handling
of the null pointer for the variable “file”.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/fs/proc/fd.c?id=caffb99b6929f41a69edbb5aef3a359bf45f3315#n20
https://elixir.bootlin.com/linux/v5.7-rc6/source/fs/proc/fd.c#L20

Will another imperative wording be preferred for the change description?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=caffb99b6929f41a69edbb5aef3a359bf45f3315#n151

Regards,
Markus