linux-kernel - Re: [PATCH v2] media: s3c-camif: Fix missing disable in tegra_adma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <e58de170-7c44-85b8-a1ac-158f35a0b14f@web.de>
Date:   Sun, 24 May 2020 11:03:02 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Qiushi Wu <wu000273@....edu>, linux-media@...r.kernel.org,
        linux-samsung-soc@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, Kangjie Lu <kjlu@....edu>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Sylwester Nawrocki <sylvester.nawrocki@...il.com>
Subject: Re: [PATCH v2] media: s3c-camif: Fix missing disable in
 tegra_adma_probe()

> "pm_runtime_enable()" was not handled by "pm_runtime_disable()"
> after a call of the function “pm_runtime_get_sync()” failed.
> Thus move the jump target “err_pm” before calling function
> "calling pm_runtime_disable()".

I find such a change description still improvable (also according to
the shown combination of quotation characters).

> ---
>
> V2: improving commit messages.

You proposed a slightly different wording variant.

> ---
>  drivers/media/platform/s3c-camif/camif-core.c | 2 +-

I suggest to delete the triple dashes before this diffstat.

I would find it nicer if you would put mail addresses from patch reviewers (like me)
also directly into the message field “Cc”.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=caffb99b6929f41a69edbb5aef3a359bf45f3315#n515

Regards,
Markus