lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:   Sun, 24 May 2020 11:03:02 +0200
From:   Markus Elfring <>
To:     Qiushi Wu <>,,
Cc:, Kangjie Lu <>,
        Mauro Carvalho Chehab <>,
        Sylwester Nawrocki <>
Subject: Re: [PATCH v2] media: s3c-camif: Fix missing disable in

> "pm_runtime_enable()" was not handled by "pm_runtime_disable()"
> after a call of the function “pm_runtime_get_sync()” failed.
> Thus move the jump target “err_pm” before calling function
> "calling pm_runtime_disable()".

I find such a change description still improvable (also according to
the shown combination of quotation characters).

> ---
> V2: improving commit messages.

You proposed a slightly different wording variant.

> ---
>  drivers/media/platform/s3c-camif/camif-core.c | 2 +-

I suggest to delete the triple dashes before this diffstat.

I would find it nicer if you would put mail addresses from patch reviewers (like me)
also directly into the message field “Cc”.


Powered by blists - more mailing lists