linux-kernel - Re: [PATCH 1/2] crypto: virtio: Fix src/dst scatterlist calculation in __virtio_crypto_skcipher_do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <21478291-9191-1da3-a7e5-65e87c743a3c@web.de>
Date:   Mon, 25 May 2020 08:05:02 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     longpeng2@...wei.com, linux-crypto@...r.kernel.org,
        virtualization@...ts.linux-foundation.org
Cc:     linux-kernel@...r.kernel.org,
        Arei Gonglei <arei.gonglei@...wei.com>,
        Corentin Labbe <clabbe@...libre.com>,
        "David S. Miller" <davem@...emloft.net>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Jason Wang <jasowang@...hat.com>,
        "Michael S. Tsirkin" <mst@...hat.com>
Subject: Re: [PATCH 1/2] crypto: virtio: Fix src/dst scatterlist calculation
 in __virtio_crypto_skcipher_do_req()

> The system will crash when we insmod crypto/tcrypt.ko whit mode=38.

* I suggest to use the word “with” in this sentence.

* Will it be helpful to explain the passed mode number?

> BTW I add a check for sg_nents_for_len() its return value since
> sg_nents_for_len() function could fail.

Please reconsider also development consequences for this suggestion.
Will a separate update step be more appropriate for the addition of
an input parameter validation?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=9cb1fd0efd195590b828b9b865421ad345a4a145#n138

Would you like to add the tag “Fixes” to the commit message?

Regards,
Markus