lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 25 May 2020 08:30:25 +0200 From: Markus Elfring <Markus.Elfring@....de> To: longpeng2@...wei.com, linux-crypto@...r.kernel.org, virtualization@...ts.linux-foundation.org Cc: Arei Gonglei <arei.gonglei@...wei.com>, Corentin Labbe <clabbe@...libre.com>, "David S. Miller" <davem@...emloft.net>, Herbert Xu <herbert@...dor.apana.org.au>, Jason Wang <jasowang@...hat.com>, "Michael S. Tsirkin" <mst@...hat.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH 2/2] crypto: virtio: Fix use-after-free in virtio_crypto_skcipher_finalize_req() > … So the system will crash > at last when this memory be used again. I would prefer a wording with less typos here. > We can free the resources before calling ->complete to fix this issue. * An imperative wording can be nicer. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=9cb1fd0efd195590b828b9b865421ad345a4a145#n151 * You proposed to move a call of the function “crypto_finalize_skcipher_request”. How does this change fit to the mentioned position? * Would you like to add the tag “Fixes” to the commit message? Regards, Markus
Powered by blists - more mailing lists