linux-kernel - Re: [PATCH v3 5/7] bus: mhi: core: Introduce debugfs entries and counters for MHI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200525063513.GA59195@kroah.com>
Date:   Mon, 25 May 2020 08:35:13 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Bhaumik Bhatt <bbhatt@...eaurora.org>
Cc:     manivannan.sadhasivam@...aro.org, linux-arm-msm@...r.kernel.org,
        hemantk@...eaurora.org, jhugo@...eaurora.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 5/7] bus: mhi: core: Introduce debugfs entries and
 counters for MHI

On Mon, May 18, 2020 at 01:03:59PM -0700, Bhaumik Bhatt wrote:
> +void mhi_create_debugfs(struct mhi_controller *mhi_cntrl)
> +{
> +	if (IS_ERR_OR_NULL(mhi_debugfs_root))
> +		return;

Why?  Should not matter.

> +	mhi_cntrl->debugfs_dentry =
> +			debugfs_create_dir(dev_name(mhi_cntrl->cntrl_dev),
> +					   mhi_debugfs_root);
> +	if (IS_ERR_OR_NULL(mhi_cntrl->debugfs_dentry))
> +		return;

No need for this check either, just call debugfs and keep on moving :)

thanks,

greg k-h