linux-kernel - Re: [2/2] crypto: virtio: Fix use-after-free in virtio_crypto_skcipher_finalize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cbd8ab27-71c3-2fb0-2fa3-263901596773@web.de>
Date:   Mon, 25 May 2020 09:36:10 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Longpeng <longpeng2@...wei.com>, linux-crypto@...r.kernel.org,
        virtualization@...ts.linux-foundation.org
Cc:     Arei Gonglei <arei.gonglei@...wei.com>,
        Corentin Labbe <clabbe@...libre.com>,
        "David S. Miller" <davem@...emloft.net>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Jason Wang <jasowang@...hat.com>,
        "Michael S. Tsirkin" <mst@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [2/2] crypto: virtio: Fix use-after-free in
 virtio_crypto_skcipher_finalize_req()

> Could you help me to make the sentence better?

How do you think about a wording variant like the following?

  So the system will crash when this memory will be used again.


>> * You proposed to move a call of the function “crypto_finalize_skcipher_request”.
>>   How does this change fit to the mentioned position?
>>
> The resources which need to be freed is not used anymore, but the pointers
> of these resources may be changed in the function
> "crypto_finalize_skcipher_request", so free these resources before call the
> function is suitable.

Another alternative:
  The resources which need to be cleaned up are not used any more.
  But the pointers of these resources may be changed in the
  function “crypto_finalize_skcipher_request”.
  Thus release specific resources before calling this function.

Regards,
Markus