linux-kernel - Re: Re: [PATCH] media: smiapp: Fix runtime PM imbalance on error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <142e32cb.c76d2.1724ae58dd9.Coremail.dinghao.liu@zju.edu.cn>
Date:   Mon, 25 May 2020 16:14:17 +0800 (GMT+08:00)
From:   dinghao.liu@....edu.cn
To:     "Sakari Ailus" <sakari.ailus@...ux.intel.com>
Cc:     kjlu@....edu, "Mauro Carvalho Chehab" <mchehab@...nel.org>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: Re: [PATCH] media: smiapp: Fix runtime PM imbalance on error

> Hi Dinghao,
> 
> Thanks for the patch.
> 
> On Fri, May 22, 2020 at 05:03:13PM +0800, Dinghao Liu wrote:
> > When v4l2_async_register_subdev_sensor_common() returns
> > an error code, a pairing runtime PM usage counter
> > decrement is needed to keep the counter balanced.
> > 
> > Signed-off-by: Dinghao Liu <dinghao.liu@....edu.cn>
> > ---
> >  drivers/media/i2c/smiapp/smiapp-core.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/media/i2c/smiapp/smiapp-core.c b/drivers/media/i2c/smiapp/smiapp-core.c
> > index 5e4f6a2ef78e..43ba63c48a87 100644
> > --- a/drivers/media/i2c/smiapp/smiapp-core.c
> > +++ b/drivers/media/i2c/smiapp/smiapp-core.c
> > @@ -3103,6 +3103,7 @@ static int smiapp_probe(struct i2c_client *client)
> >  	return 0;
> >  
> >  out_disable_runtime_pm:
> > +	pm_runtime_put_autosuspend(&client->dev);
> 
> Can you use pm_runtime_put_noidle(), as the device musn't be powered off
> here yet?
> 
> >  	pm_runtime_disable(&client->dev);
> >  
> >  out_media_entity_cleanup:
> 
> -- 
> Regards,
> 
> Sakari Ailus

OK. I will fix this in the next version of patch.

Regards,
Dinghao