linux-kernel - Re: [PATCH v2] workqueue: Delete duplicate kfree() call for “rescuer” from rcu_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <efe09ccb-914c-6573-b88f-919bddff20a5@web.de>
Date:   Mon, 25 May 2020 10:20:45 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Zhang Qiang <qiang.zhang@...driver.com>, Tejun Heo <tj@...nel.org>,
        Lai Jiangshan <jiangshanlai@...il.com>
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH v2] workqueue: Delete duplicate kfree() call for “rescuer” from rcu_free_wq()

> The duplicate memory release should be deleted from the implementation
> of the callback function "rcu_free_wq".

I would find it nicer if you would have extended my simple wording suggestion.

1. Mention conditions:
   The callback function “rcu_free_wq” could be called after memory was released
   for “rescuer” already.

2. Specify the desired action:
   Thus delete a misplaced call of the function “kfree”.

3. Please keep the patch versioning consistent.
   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=9cb1fd0efd195590b828b9b865421ad345a4a145#n709

Regards,
Markus