linux-kernel - Re: [PATCH v2] USB: serial: qcserial: Add DW5816e QDL support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d0535328-6773-4565-82b9-1975cf875a8d@footclan.ninja>
Date:   Mon, 25 May 2020 20:33:31 +1000
From:   Matt Jolly <kangie@...tclan.ninja>
To:     Johan Hovold <johan@...nel.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] USB: serial: qcserial: Add DW5816e QDL support

> On 25/5/20 7:39 pm, Johan Hovold wrote:
>> Hmm. I'd a call a build breakage a bit more than just a "typo" as it
>> indicates this patch was never tested at all before being submitted.
I applied, built, and tested it against the sources for the kernel I run 
on my machine, but made several silly mistakes: both manually applying 
the patch to my copy of the repo (which is not my running kernel), and 
not build testing that change before submission. Not good indeed.

I could definitely have been more descriptive in the change notes.

Consider me appropriately chastised!