linux-kernel - Re: Re: [PATCH] power: supply: bq24190

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <29d2d7f2.c835d.1724b6ac5fc.Coremail.dinghao.liu@zju.edu.cn>
Date:   Mon, 25 May 2020 18:39:48 +0800 (GMT+08:00)
From:   dinghao.liu@....edu.cn
To:     "Rafael J. Wysocki" <rafael@...nel.org>
Cc:     "Kangjie Lu" <kjlu@....edu>, "Sebastian Reichel" <sre@...nel.org>,
        "Linux PM" <linux-pm@...r.kernel.org>,
        "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>
Subject: Re: Re: [PATCH] power: supply: bq24190_charger: fix runtime pm
 imbalance

> On Wed, May 20, 2020 at 10:01 AM Dinghao Liu <dinghao.liu@....edu.cn> wrote:
> >
> > pm_runtime_get_sync() increments the runtime PM usage counter even
> > it returns an error code. Thus a pairing decrement is needed on
> > the error handling path to keep the counter balanced.
> >
> > Signed-off-by: Dinghao Liu <dinghao.liu@....edu.cn>
> > ---
> >  drivers/power/supply/bq24190_charger.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/power/supply/bq24190_charger.c b/drivers/power/supply/bq24190_charger.c
> > index 453d6332d43a..4f7c6b6abb56 100644
> > --- a/drivers/power/supply/bq24190_charger.c
> > +++ b/drivers/power/supply/bq24190_charger.c
> > @@ -481,8 +481,10 @@ static ssize_t bq24190_sysfs_store(struct device *dev,
> >                 return ret;
> >
> >         ret = pm_runtime_get_sync(bdi->dev);
> > -       if (ret < 0)
> > +       if (ret < 0) {
> > +               pm_runtime_put_autosuspend(bdi->dev);
> 
> The autosuspend thing is not necessary here, because the suspend is
> not going to work anyway due to the resume error, so this can be
> _put_noidle().
> 
> You might as well do something like
> 
> count = ret;
> goto out;
> 
> here and add an "out" label before the pm_runtime_mark_last_busy() call, though.
> 
> >                 return ret;
> > +       }
> >
> >         ret = bq24190_write_mask(bdi, info->reg, info->mask, info->shift, v);
> >         if (ret)
> > --
> > 2.17.1
> >

Thank you for your advice! I will fix this in the next version of patch.

Regards,
Dinghao