linux-kernel - Re: [PATCH 1/2] software node: implement software_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <13de8a28-9ea9-bf44-c4e7-d5bfb63c81fd@infradead.org>
Date:   Sun, 24 May 2020 19:44:16 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Guenter Roeck <linux@...ck-us.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Cc:     Naresh Kamboju <naresh.kamboju@...aro.org>,
        kernel test robot <rong.a.chen@...el.com>,
        stable <stable@...r.kernel.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Brendan Higgins <brendanhiggins@...gle.com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Petr Mladek <pmladek@...e.com>,
        "Rafael J . Wysocki" <rafael.j.wysocki@...el.com>,
        Rasmus Villemoes <linux@...musvillemoes.dk>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH 1/2] software node: implement software_node_unregister()

On 5/24/20 9:43 AM, Guenter Roeck wrote:
> On 5/24/20 8:30 AM, Greg Kroah-Hartman wrote:
>> Sometimes it is better to unregister individual nodes instead of trying
>> to do them all at once with software_node_unregister_nodes(), so create
>> software_node_unregister() so that you can unregister them one at a
>> time.
>>
>> This is especially important when creating nodes in a hierarchy, with
>> parent -> children representations.  Children always need to be removed
>> before a parent is, as the swnode logic assumes this is going to be the
>> case.
>>
>> Fix up the lib/test_printf.c fwnode_pointer() test which to use this new
>> function as it had the problem of tearing things down in the backwards
>> order.
>>
>> Fixes: f1ce39df508d ("lib/test_printf: Add tests for %pfw printk modifier")
>> Reported-by: Naresh Kamboju <naresh.kamboju@...aro.org>
>> Reported-by: kernel test robot <rong.a.chen@...el.com>
>> Cc: stable <stable@...r.kernel.org>
>> Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>> Cc: Brendan Higgins <brendanhiggins@...gle.com>
>> Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
>> Cc: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
>> Cc: Petr Mladek <pmladek@...e.com>
>> Cc: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
>> Cc: Randy Dunlap <rdunlap@...radead.org>
>> Cc: Rasmus Villemoes <linux@...musvillemoes.dk>
>> Cc: Sakari Ailus <sakari.ailus@...ux.intel.com>
>> Cc: Sergey Senozhatsky <sergey.senozhatsky@...il.com>
>> Cc: Steven Rostedt <rostedt@...dmis.org>
>> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> 
> Both patches pass my boot tests on arm64 and arm64be (I didn't test any others).
> So, FWIW,
> 
> Tested-by: Guenter Roeck <linux@...ck-us.net>
> 
> I wasn't sure it the two patches replace or fix commit 4ef12f719802 ("kobject:
> Make sure the parent does not get released before its children"), so I tried
> to re-apply 4ef12f719802 on top of the two patches. Unfortunately that still
> results in crashes and UAF messages.

Yes, that kobject patch has been reverted:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e6764aa0e5530066dd969eccea2a1a7d177859a8

and these 2 patches are to be used instead.

thanks.
-- 
~Randy