linux-kernel - Re: [PATCH v2 2/2] phy: Remove CONFIG_ARCH_* check for related subdir in Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <10793802.6Woqi72AOj@diego>
Date:   Mon, 25 May 2020 17:01:38 +0200
From:   Heiko Stübner <heiko@...ech.de>
To:     Tiezhu Yang <yangtiezhu@...ngson.cn>
Cc:     Kishon Vijay Abraham I <kishon@...com>,
        Vinod Koul <vkoul@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Xuefeng Li <lixuefeng@...ngson.cn>
Subject: Re: [PATCH v2 2/2] phy: Remove CONFIG_ARCH_* check for related subdir in Makefile

Am Montag, 25. Mai 2020, 15:08:58 CEST schrieb Tiezhu Yang:
> If CONFIG_ARCH_ROCKCHIP is not set but COMPILE_TEST is set, the file in
> the subdir rockchip can not be built due to CONFIG_ARCH_ROCKCHIP check
> in drivers/phy/Makefile.
> 
> Since the related configs in drivers/phy/rockchip/Kconfig depend on
> ARCH_ROCKCHIP, so remove CONFIG_ARCH_ROCKCHIP check for subdir rockchip
> in drivers/phy/Makefile.
> 
> The other CONFIG_ARCH_* about allwinner, amlogic, mediatek, renesas and
> tegra have the same situation, so remove them too.
> 
> Signed-off-by: Tiezhu Yang <yangtiezhu@...ngson.cn>

I did check the other vendor directories and all options there do
seem to depend on some ARCH_foo || COMPILE_TEST variant, so

Reviewed-by: Heiko Stuebner <heiko@...ech.de>


Heiko

> ---
> 
> v2:
>   - Remove all the CONFIG_ARCH_* check for related subdir in Makefile
>   - Modify the patch subject and update commit message
> 
>  drivers/phy/Makefile | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/phy/Makefile b/drivers/phy/Makefile
> index 310c149..16e2622 100644
> --- a/drivers/phy/Makefile
> +++ b/drivers/phy/Makefile
> @@ -8,24 +8,24 @@ obj-$(CONFIG_GENERIC_PHY_MIPI_DPHY)	+= phy-core-mipi-dphy.o
>  obj-$(CONFIG_PHY_LPC18XX_USB_OTG)	+= phy-lpc18xx-usb-otg.o
>  obj-$(CONFIG_PHY_XGENE)			+= phy-xgene.o
>  obj-$(CONFIG_PHY_PISTACHIO_USB)		+= phy-pistachio-usb.o
> -obj-$(CONFIG_ARCH_SUNXI)		+= allwinner/
> -obj-$(CONFIG_ARCH_MESON)		+= amlogic/
> -obj-$(CONFIG_ARCH_MEDIATEK)		+= mediatek/
> -obj-$(CONFIG_ARCH_RENESAS)		+= renesas/
> -obj-$(CONFIG_ARCH_ROCKCHIP)		+= rockchip/
> -obj-$(CONFIG_ARCH_TEGRA)		+= tegra/
> -obj-y					+= broadcom/	\
> +obj-y					+= allwinner/	\
> +					   amlogic/	\
> +					   broadcom/	\
>  					   cadence/	\
>  					   freescale/	\
>  					   hisilicon/	\
>  					   intel/	\
>  					   lantiq/	\
>  					   marvell/	\
> +					   mediatek/	\
>  					   motorola/	\
>  					   mscc/	\
>  					   qualcomm/	\
>  					   ralink/	\
> +					   renesas/	\
> +					   rockchip/	\
>  					   samsung/	\
>  					   socionext/	\
>  					   st/		\
> +					   tegra/	\
>  					   ti/
>