linux-kernel - Re: [RESEND PATCH] drm/vc4: hdmi: Silence pixel clock error on -EPROBE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 25 May 2020 17:12:37 +0200
From:   Daniel Vetter <daniel@...ll.ch>
To:     James Hilliard <james.hilliard1@...il.com>
Cc:     dri-devel@...ts.freedesktop.org, Eric Anholt <eric@...olt.net>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>, linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH] drm/vc4: hdmi: Silence pixel clock error on
 -EPROBE_DEFER

On Sun, May 24, 2020 at 07:28:59PM -0600, James Hilliard wrote:
> If the vc4 hdmi driver loads before the pixel clock is available we
> see a spurious "*ERROR* Failed to get pixel clock" error.
> 
> Signed-off-by: James Hilliard <james.hilliard1@...il.com>
> ---
> no response in over 2 weeks

Thanks for poking again, not sure who exactly is supporting drm/vc4
nowadays. Eric at least doesn't work at broadcom anymore.

I queued up the patch in drm-misc-next.
-Daniel

> ---
>  drivers/gpu/drm/vc4/vc4_hdmi.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
> index 340719238753..6d4ee3f6b445 100644
> --- a/drivers/gpu/drm/vc4/vc4_hdmi.c
> +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
> @@ -1338,8 +1338,10 @@ static int vc4_hdmi_bind(struct device *dev, struct device *master, void *data)
>  
>  	hdmi->pixel_clock = devm_clk_get(dev, "pixel");
>  	if (IS_ERR(hdmi->pixel_clock)) {
> -		DRM_ERROR("Failed to get pixel clock\n");
> -		return PTR_ERR(hdmi->pixel_clock);
> +		ret = PTR_ERR(hdmi->pixel_clock);
> +		if (ret != -EPROBE_DEFER)
> +			DRM_ERROR("Failed to get pixel clock\n");
> +		return ret;
>  	}
>  	hdmi->hsm_clock = devm_clk_get(dev, "hdmi");
>  	if (IS_ERR(hdmi->hsm_clock)) {
> -- 
> 2.25.1
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch