linux-kernel - Re: [PATCH v2] media: coda: Fix runtime PM imbalance in coda

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 25 May 2020 17:15:08 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Dinghao Liu <dinghao.liu@....edu.cn>, linux-media@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, Kangjie Lu <kjlu@....edu>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Philipp Zabel <p.zabel@...gutronix.de>
Subject: Re: [PATCH v2] media: coda: Fix runtime PM imbalance in coda_probe()

> When coda_firmware_request() returns an error code,
> a pairing runtime PM usage counter decrement is needed
> to keep the counter balanced.

* I suggest to add an imperative wording.
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=9cb1fd0efd195590b828b9b865421ad345a4a145#n151

* Would you like to add the tag “Fixes” to the commit message?

> Changelog:

I propose to omit this line.

> ---
>  drivers/media/platform/coda/coda-common.c | 2 ++

I find it nicer to replace the triple dashes before this diffstat
by a blank line.

Regards,
Markus