linux-kernel - Re: [PATCH v2 1/4] pwm: jz4740: Drop dependency on MACH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200525153333.4wsm3dhkdzjjq6pc@pengutronix.de>
Date:   Mon, 25 May 2020 17:33:33 +0200
From:   Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
To:     Paul Cercueil <paul@...pouillou.net>
Cc:     Thierry Reding <thierry.reding@...il.com>, od@...c.me,
        linux-pwm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/4] pwm: jz4740: Drop dependency on MACH_INGENIC

Hello,

On Mon, May 25, 2020 at 02:57:19PM +0200, Paul Cercueil wrote:
> Depending on MACH_INGENIC prevent us from creating a generic kernel that
> works on more than one MIPS board. Instead, we just depend on MIPS being
> set.
> 
> Signed-off-by: Paul Cercueil <paul@...pouillou.net>
> Acked-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Nitpick: Your S-o-B should come last. So if you added my Ack the
resulting commit then has (after being picked up by a maintainer):

 .	Acked-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
 .	Signed-off-by: Paul Cercueil <paul@...pouillou.net>
 .	Signed-off-by: Peter Maintainer <...>

(quoted to not let patchwork pick up tags) while when the Ack is added
by the maintainer the result is

 .	Signed-off-by: Paul Cercueil <paul@...pouillou.net>
 .	Acked-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
 .	Signed-off-by: Peter Maintainer <...>

. So the order tells the reader who added a tag.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |